Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: at_commons:4.0.1 uptake and increased pub points [at_onboarding_flutter] #800

Merged
merged 2 commits into from
Feb 7, 2024
Merged

fix: at_commons:4.0.1 uptake and increased pub points [at_onboarding_flutter] #800

merged 2 commits into from
Feb 7, 2024
+27 −25

Conversation

Sardar1208
Copy link
Contributor

- What I did - updated all dependencies (including at_commons: 4.0.1) and fixed formatting
at_commons ticket link - #794
pub points ticket - https://github.com/atsign-foundation/apps/issues/780

@Sardar1208 Sardar1208 changed the title fix: updated dependencies and increased pub points fix: updated dependencies and increased pub points [at_onboarding_flutter] Feb 6, 2024
@Sardar1208 Sardar1208 changed the title fix: updated dependencies and increased pub points [at_onboarding_flutter] fix: at_commons:4.0.1 uptake and increased pub points [at_onboarding_flutter] Feb 6, 2024
@Sardar1208 Sardar1208 merged commit 4cdac9c into trunk Feb 7, 2024
16 of 17 checks passed
@Sardar1208 Sardar1208 deleted the fix/onboarding_deps_and_pub_points branch February 7, 2024 08:53
@gkc
Copy link
Contributor

gkc commented Feb 7, 2024 •
edited
Loading

@sachins-geekyants Why was it OK to merge the PR even though the melos-bootstrap check failed?

@Sardar1208
Copy link
Contributor Author

@gkc The deps conflict shown here is not happening when we go a flutter pub get.

Screenshot 2024-02-07 at 5 40 02 PM

@gkc
Copy link
Contributor

gkc commented Feb 7, 2024

@gkc The deps conflict shown here is not happening when we go a flutter pub get.

OK ... would be good to know why the melos-bootstrap check is failing though

@sachins-geekyants
Copy link
Contributor

melos-bootstrap issue was reproduced locally in at_contacts_flutter package because of at_common conflict between onboarding and contact_flutter package.

In next PR, these conflicts will be reolved.

cc: @gkc

@gkc
Copy link
Contributor

gkc commented Feb 7, 2024

melos-bootstrap issue was reproduced locally in at_contacts_flutter package because of at_common conflict between onboarding and contact_flutter package.

In next PR, these conflicts will be reolved.

cc: @gkc

Thanks @sachins-geekyants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonle-geekyants sonle-geekyants sonle-geekyants approved these changes

@sachins-geekyants sachins-geekyants sachins-geekyants approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sardar1208 @gkc @sachins-geekyants @sonle-geekyants